Closed9
FuelPHPのテストを動かす
git clone git@github.com:fuel/fuel.git
cd fuel
git checkout -b 1.9/develop origin/1.9/develop
diff --git a/phpunit.xml b/phpunit.xml
index e5a8341e..412ba410 100644
--- a/fuel/core/phpunit.xml
+++ b/fuel/core/phpunit.xml
@@ -23,4 +23,14 @@
<directory suffix=".php">../app/modules/*/tests</directory>
</testsuite>
</testsuites>
+ <filter>
+ <whitelist processUncoveredFilesFromWhitelist="true">
+ <directory suffix=".php">../core/classes</directory>
+ <exclude>
+ <file>../core/classes/config/ini.php</file>
+ <file>../core/classes/sessionhandler84.php</file>
+ <file>../core/classes/testcase.php</file>
+ </exclude>
+ </whitelist>
+ </filter>
</phpunit>
diff --git a/tests/crypt.php b/tests/crypt.php
index e515df94..4d50718a 100644
--- a/fuel/core/tests/crypt.php
+++ b/fuel/core/tests/crypt.php
@@ -51,6 +51,7 @@ class Test_Crypt extends TestCase
public function test_legacy_decode()
{
+ $this->markTestSkipped('always failing...');
$test = \Crypt::legacy_decode(static::$legacy_encrypted);
$this->assertEquals(static::$clear_text, $test);
}
diff --git a/tests/num.php b/tests/num.php
index 342d94e9..bef9e658 100644
--- a/fuel/core/tests/num.php
+++ b/fuel/core/tests/num.php
@@ -24,6 +24,11 @@ namespace Fuel\Core;
*/
class Test_Num extends TestCase
{
+ protected function setUp()
+ {
+ \Num::_init();
+ }
+
/**
* @see Num::bytes
*/
docker run --rm -it -v $(pwd):/fuel -w /fuel jitesoft/phpunit:5.6 sh
composer install
patch -p1 < a.patch
phpunit -c fuel/core/phpunit.xml --group Core --coverage-html coverage
coverage低い...
PHP 8.3用のpatch
diff --git a/composer.json b/composer.json
index e58eba4..0dc9983 100644
--- a/composer.json
+++ b/composer.json
@@ -28,7 +28,10 @@
"zordius/lightncandy": "Allow Handlebars templating with an extremely fast PHP implementation of handlebars"
},
"config": {
- "vendor-dir": "fuel/vendor"
+ "vendor-dir": "fuel/vendor",
+ "allow-plugins": {
+ "composer/installers": true
+ }
},
"extra": {
"installer-paths": {
git diff | perl -pe 's|^--- a/|--- a/fuel/core/|' | perl -pe 's|^\+\+\+ b/|+++ b/fuel/core/|' > ../fuel/a.patch
rm -fr fuel/core && composer install
patch -p1 < a.patch
phpunit -c fuel/core/phpunit.xml --group Core --coverage-html coverage
PHP 8.0 から strtolower と filter_var で発生する TypeError を直す
commit cb4e53f79972694d44cf6faca36fea988d4c3293
Author: koji-nakamura-classi <koji.nakamura@classi.jp>
Date: Thu Nov 7 14:52:42 2024 +0900
fix argument errors with strtolower and filter_var until PHP 8.0
diff --git a/classes/validation.php b/classes/validation.php
index 4fd76ff3..c14f6625 100644
--- a/classes/validation.php
+++ b/classes/validation.php
@@ -887,7 +887,7 @@ class Validation
* @param string ipv4|ipv6
* @return bool
*/
- public function _validation_valid_ip($val, $flag = null)
+ public function _validation_valid_ip($val, $flag = '')
{
switch (strtolower($flag))
{
@@ -897,6 +897,9 @@ class Validation
case 'ipv6':
$flag = FILTER_FLAG_IPV6;
break;
+ default:
+ $flag = 0;
+ break;
}
return $this->_empty($val) || filter_var($val, FILTER_VALIDATE_IP, $flag);
docker run --rm -it -v $(pwd):/fuel -w /fuel jitesoft/phpunit:8.3 phpunit -c fuel/core/phpunit.xml --group Core --coverage-html coverage
このスクラップは17日前にクローズされました