<h1 id="%E7%B5%8C%E7%B7%AF" data-line="0" class="code-line">
<a class="header-anchor-link" href="#%E7%B5%8C%E7%B7%AF" aria-hidden="true"></a> 経緯</h1>
<p data-line="2" class="code-line">RubyKaigi 2025に参加し、#kaigieffectとしてOSS活動を始めたいと考えていました。業務でGraphQLを使用していることもあり、<a href="https://github.com/rmosolgo/graphql-ruby" target="_blank" rel="nofollow noopener noreferrer">graphql-ruby</a>に触れてみることに決めました。どうせならRubyの最新（Head）バージョンで開発しようとセットアップを進めていたところ、Headでは動作しない箇所を見つけたため、PRを送ることにしました。</p>
<h1 id="%E9%96%8B%E7%99%BA%E7%92%B0%E5%A2%83%E3%81%AE%E3%82%BB%E3%83%83%E3%83%88%E3%82%A2%E3%83%83%E3%83%97" data-line="4" class="code-line">
<a class="header-anchor-link" href="#%E9%96%8B%E7%99%BA%E7%92%B0%E5%A2%83%E3%81%AE%E3%82%BB%E3%83%83%E3%83%88%E3%82%A2%E3%83%83%E3%83%97" aria-hidden="true"></a> 開発環境のセットアップ</h1>
<p data-line="6" class="code-line">セットアップ手順は以下の通りです。</p>
<blockquote data-line="8" class="code-line">
<p data-line="8" class="code-line">Get your own copy of graphql-ruby by forking rmosolgo/graphql-ruby on GitHub and cloning your fork.</p>
<p data-line="10" class="code-line">Then, install the dependencies:</p>
<ul data-line="12" class="code-line">
<li data-line="12" class="code-line">Install SQLite3 and MongoDB (eg, brew install sqlite &amp;&amp; brew tap mongodb/brew &amp;&amp; brew install mongodb-community)</li>
<li data-line="13" class="code-line">bundle install</li>
<li data-line="14" class="code-line">rake compile # If you get warnings at this step, you can ignore them.</li>
<li data-line="15" class="code-line">Optional: Ragel is required to build the lexer</li>
</ul>
</blockquote>
<p data-line="17" class="code-line"><span class="embed-block zenn-embedded zenn-embedded-card"><iframe id="zenn-embedded__48e026163ae12" src="https://embed.zenn.studio/card#zenn-embedded__48e026163ae12" data-content="https%3A%2F%2Fgraphql-ruby.org%2Fdevelopment" frameborder="0" scrolling="no" loading="lazy"></iframe></span><a href="https://graphql-ruby.org/development" style="display:none" target="_blank" rel="nofollow noopener noreferrer">https://graphql-ruby.org/development</a></p>
<h2 id="%E3%83%AD%E3%83%BC%E3%82%AB%E3%83%AB%E7%92%B0%E5%A2%83" data-line="19" class="code-line">
<a class="header-anchor-link" href="#%E3%83%AD%E3%83%BC%E3%82%AB%E3%83%AB%E7%92%B0%E5%A2%83" aria-hidden="true"></a> ローカル環境</h2>
<div class="code-block-container"><pre><code class="code-line" data-line="21">❯ ruby -v
ruby 3.5.0dev (2025-01-18T00:19:17Z master 65a7c69188) +PRISM [arm64-darwin23]

❯ bundle -v
Bundler version 2.7.0.dev
</code></pre></div><h2 id="bison%E3%81%AE%E3%83%90%E3%83%BC%E3%82%B8%E3%83%A7%E3%83%B3%E3%81%8C%E4%BD%8E%E3%81%84" data-line="29" class="code-line">
<a class="header-anchor-link" href="#bison%E3%81%AE%E3%83%90%E3%83%BC%E3%82%B8%E3%83%A7%E3%83%B3%E3%81%8C%E4%BD%8E%E3%81%84" aria-hidden="true"></a> bisonのバージョンが低い</h2>
<p data-line="31" class="code-line"><code>bundle install</code>後の<code>rake compile</code>にてエラーが発生しました。bisonのバージョンが低いことが原因のようです。</p>
<div class="code-block-container"><pre><code class="code-line" data-line="34">❯ rake compile
cd tmp/arm64-darwin23/graphql_c_parser_ext/3.5.0
/opt/homebrew/bin/gmake
yacc  ../../../../graphql-c_parser/ext/graphql_c_parser_ext/parser.y
../../../../graphql-c_parser/ext/graphql_c_parser_ext/parser.y:1.10-14: require bison 3.8, but have 2.3
gmake: *** [&lt;builtin&gt;: parser.c] Error 63
rake aborted!
Command failed with status (2): [/opt/homebrew/bin/gmake]

Tasks: TOP =&gt; compile =&gt; compile:arm64-darwin23 =&gt; compile:graphql_c_parser_ext:arm64-darwin23 =&gt; copy:graphql_c_parser_ext:arm64-darwin23:3.5.0 =&gt; tmp/arm64-darwin23/graphql_c_parser_ext/3.5.0/graphql_c_parser_ext.bundle
(See full trace by running task with --trace)
</code></pre></div><p data-line="48" class="code-line">bisonを新しくインストールし、PATHを通して、シェルを再起動して対応します。</p>
<div class="code-block-container"><pre><code class="code-line" data-line="50">brew install bison
echo 'export PATH="/opt/homebrew/opt/bison/bin:$PATH"' &gt;&gt; ~/.zsh_profile
exec $SHELL -l
</code></pre></div><p data-line="56" class="code-line">bisonのバージョンが更新されました👏</p>
<div class="code-block-container"><pre><code class="code-line" data-line="58">❯ bison --version
bison (GNU Bison) 3.8.2
Written by Robert Corbett and Richard Stallman.

Copyright (C) 2021 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
</code></pre></div><p data-line="68" class="code-line"><code>rake compile</code>のリトライ！</p>
<div class="code-block-container"><pre><code class="code-line" data-line="70">❯ rake compile
cd tmp/arm64-darwin23/graphql_c_parser_ext/3.5.0
/opt/homebrew/bin/gmake
yacc  ../../../../graphql-c_parser/ext/graphql_c_parser_ext/parser.y
../../../../graphql-c_parser/ext/graphql_c_parser_ext/parser.y:1.1-8: warning: POSIX Yacc does not support %require [-Wyacc]
    1 | %require "3.8"
      | ^~~~~~~~
../../../../graphql-c_parser/ext/graphql_c_parser_ext/parser.y:1.10-14: warning: POSIX Yacc does not support string literals [-Wyacc]
    1 | %require "3.8"
      |          ^~~~~
../../../../graphql-c_parser/ext/graphql_c_parser_ext/parser.y:2.1-7: warning: POSIX Yacc does not support %define [-Wyacc]
    2 | %define api.pure full
      | ^~~~~~~
../../../../graphql-c_parser/ext/graphql_c_parser_ext/parser.y:3.1-7: warning: POSIX Yacc does not support %define [-Wyacc]
    3 | %define parse.error detailed
      | ^~~~~~~
../../../../graphql-c_parser/ext/graphql_c_parser_ext/parser.y: warning: 19 shift/reduce conflicts [-Wconflicts-sr]
../../../../graphql-c_parser/ext/graphql_c_parser_ext/parser.y: warning: 62 reduce/reduce conflicts [-Wconflicts-rr]
../../../../graphql-c_parser/ext/graphql_c_parser_ext/parser.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples
mv -f y.tab.c parser.c
compiling parser.c
y.tab.c:1669:9: warning: variable 'yynerrs' set but not used [-Wunused-but-set-variable]
 1669 |     int yynerrs = 0;
      |         ^
../../../../graphql-c_parser/ext/graphql_c_parser_ext/parser.y:896:61: warning: function 'yyerror' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
  896 | void yyerror(VALUE parser, VALUE filename, const char *msg) {
      |                                                             ^
2 warnings generated.
linking shared-object graphql/graphql_c_parser_ext.bundle
cd -
mkdir -p tmp/arm64-darwin23/stage/graphql-c_parser/lib/graphql
/opt/homebrew/bin/gmake install sitearchdir=../../../../graphql-c_parser/lib/graphql sitelibdir=../../../../graphql-c_parser/lib/graphql target_prefix=
/opt/homebrew/bin/ginstall -c -m 0755 graphql_c_parser_ext.bundle ../../../../graphql-c_parser/lib/graphql
cp tmp/arm64-darwin23/graphql_c_parser_ext/3.5.0/graphql_c_parser_ext.bundle tmp/arm64-darwin23/stage/graphql-c_parser/lib/graphql/graphql_c_parser_ext.bundle
</code></pre></div><p data-line="107" class="code-line">むむ〜。なんかゴニョゴニョ出てる。けど、warningは無視していいとのことなので無視。</p>
<blockquote data-line="109" class="code-line">
<p data-line="109" class="code-line">rake compile # If you get warnings at this step, you can ignore them.</p>
</blockquote>
<h1 id="unit-tests%E3%81%AE%E5%AE%9F%E8%A1%8C" data-line="111" class="code-line">
<a class="header-anchor-link" href="#unit-tests%E3%81%AE%E5%AE%9F%E8%A1%8C" aria-hidden="true"></a> Unit Testsの実行</h1>
<p data-line="113" class="code-line">環境のセットアップができたらテストを実行してみます。</p>
<div class="code-block-container"><pre><code class="code-line" data-line="115">bundle exec rake test   # tests only
</code></pre></div><p data-line="118" class="code-line"><span class="embed-block zenn-embedded zenn-embedded-card"><iframe id="zenn-embedded__e9e663bf3d896" src="https://embed.zenn.studio/card#zenn-embedded__e9e663bf3d896" data-content="https%3A%2F%2Fgraphql-ruby.org%2Fdevelopment%23running-the-tests" frameborder="0" scrolling="no" loading="lazy"></iframe></span><a href="https://graphql-ruby.org/development#running-the-tests" style="display:none" target="_blank" rel="nofollow noopener noreferrer">https://graphql-ruby.org/development#running-the-tests</a></p>
<div class="code-block-container"><pre><code class="code-line" data-line="120">❯ bundle exec rake test
/Users/koyamasuda/.rbenv/versions/ruby-dev/lib/ruby/3.5.0+0/readline.rb:4: warning: reline was loaded from the standard library, but is not part of the default gems starting from Ruby 3.5.0.
You can add reline to your Gemfile or gemspec to silence this warning.
/Users/koyamasuda/.rbenv/versions/ruby-dev/lib/ruby/gems/3.5.0+0/gems/byebug-12.0.0/lib/byebug/commands/irb.rb:4: warning: irb was loaded from the standard library, but is not part of the default gems starting from Ruby 3.5.0.
You can add irb to your Gemfile or gemspec to silence this warning.
/Users/koyamasuda/.rbenv/versions/ruby-dev/lib/ruby/gems/3.5.0+0/gems/libev_scheduler-0.2/lib/libev_scheduler.rb:16: warning: method redefined; discarding old process_wait
/Users/koyamasuda/personal/graphql-ruby/spec/spec_helper.rb:47: warning: benchmark was loaded from the standard library, but is not part of the default gems starting from Ruby 3.5.0.
You can add benchmark to your Gemfile or gemspec to silence this warning.
Coverage report generated for RSpec to /Users/koyamasuda/personal/graphql-ruby/coverage.
Line Coverage: 52.43% (108 / 206)
Branch Coverage: 8.7% (2 / 23)
Lcov style coverage report generated for RSpec to /Users/koyamasuda/personal/graphql-ruby/coverage/lcov/graphql-ruby.lcov
Stopped processing SimpleCov as a previous error not related to SimpleCov has been detected
/Users/koyamasuda/.rbenv/versions/ruby-dev/lib/ruby/3.5.0+0/bundled_gems.rb:76:in 'Kernel.require': cannot load such file -- benchmark (LoadError)
Did you mean?  benchmark/ips
        from /Users/koyamasuda/.rbenv/versions/ruby-dev/lib/ruby/3.5.0+0/bundled_gems.rb:76:in 'block (2 levels) in Kernel#replace_require'
        from /Users/koyamasuda/personal/graphql-ruby/spec/spec_helper.rb:47:in '&lt;top (required)&gt;'
        from /Users/koyamasuda/.rbenv/versions/ruby-dev/lib/ruby/3.5.0+0/bundled_gems.rb:76:in 'Kernel.require'
        from /Users/koyamasuda/.rbenv/versions/ruby-dev/lib/ruby/3.5.0+0/bundled_gems.rb:76:in 'block (2 levels) in Kernel#replace_require'
        from /Users/koyamasuda/personal/graphql-ruby/spec/graphql/analysis/field_usage_spec.rb:2:in '&lt;top (required)&gt;'
        from /Users/koyamasuda/.rbenv/versions/ruby-dev/lib/ruby/3.5.0+0/bundled_gems.rb:76:in 'Kernel.require'
        from /Users/koyamasuda/.rbenv/versions/ruby-dev/lib/ruby/3.5.0+0/bundled_gems.rb:76:in 'block (2 levels) in Kernel#replace_require'
        from /Users/koyamasuda/.rbenv/versions/ruby-dev/lib/ruby/gems/3.5.0+0/gems/rake-13.2.1/lib/rake/rake_test_loader.rb:21:in 'block in &lt;main&gt;'
        from /Users/koyamasuda/.rbenv/versions/ruby-dev/lib/ruby/gems/3.5.0+0/gems/rake-13.2.1/lib/rake/rake_test_loader.rb:6:in 'Array#select'
        from /Users/koyamasuda/.rbenv/versions/ruby-dev/lib/ruby/gems/3.5.0+0/gems/rake-13.2.1/lib/rake/rake_test_loader.rb:6:in '&lt;main&gt;'
rake aborted!
Command failed with status (1)
/Users/koyamasuda/.rbenv/versions/ruby-dev/bin/bundle:25:in 'Kernel#load'
/Users/koyamasuda/.rbenv/versions/ruby-dev/bin/bundle:25:in '&lt;main&gt;'
Tasks: TOP =&gt; test
(See full trace by running task with --trace)
</code></pre></div><p data-line="154" class="code-line">おっ、落ちたぞ👀（OSS活動目的だったのでちょっと嬉しかったですw）<br>
エラーメッセージを要約すると「<code>require 'benchmark'</code>を実行しようとした際に、benchmarkライブラリが見つからず読み込めなかった」ようです。</p>
<div class="code-block-container"><pre><code class="code-line" data-line="157">/Users/koyamasuda/.rbenv/versions/ruby-dev/lib/ruby/3.5.0+0/bundled_gems.rb:76:in 'Kernel.require': cannot load such file -- benchmark (LoadError)
Did you mean?  benchmark/ips
</code></pre></div><h2 id="%E3%82%A8%E3%83%A9%E3%83%BC%E3%81%AE%E5%8E%9F%E5%9B%A0%E3%81%A8%E4%BF%AE%E6%AD%A3" data-line="162" class="code-line">
<a class="header-anchor-link" href="#%E3%82%A8%E3%83%A9%E3%83%BC%E3%81%AE%E5%8E%9F%E5%9B%A0%E3%81%A8%E4%BF%AE%E6%AD%A3" aria-hidden="true"></a> エラーの原因と修正</h2>
<div class="code-block-container"><pre><code class="code-line" data-line="164">/Users/koyamasuda/personal/graphql-ruby/spec/spec_helper.rb:47: warning: benchmark was loaded from the standard library, but is not part of the default gems starting from Ruby 3.5.0.
You can add benchmark to your Gemfile or gemspec to silence this warning.
</code></pre></div><p data-line="169" class="code-line">テスト時のwarningを見ると、Ruby3.5からは<code>benchmark</code>が標準ライブラリから外れたみたいです。<br>
エラーメッセージの通りに<code>require "benchmark/ips"</code>と直すと、<code>ostruct</code>gemでも同じことが起きているようでした。ただ、<code>ostruct</code>では既に同じ対応をしている<a href="https://github.com/rmosolgo/graphql-ruby/pull/5208" target="_blank" rel="nofollow noopener noreferrer">PR</a>がcloseしていたので、対応は<code>benchmark</code>のみに留めました。</p>
<div class="code-block-container"><pre class="diff-highlight "><code class="diff-highlight  code-line" data-line="172"><span class="token deleted-sign deleted"><span class="token prefix deleted">-</span> require "benchmark"
</span><span class="token inserted-sign inserted"><span class="token prefix inserted">+</span> require "benchmark/ips"
</span></code></pre></div><h2 id="pull-request%E3%81%AE%E4%BD%9C%E6%88%90" data-line="177" class="code-line">
<a class="header-anchor-link" href="#pull-request%E3%81%AE%E4%BD%9C%E6%88%90" aria-hidden="true"></a> Pull requestの作成</h2>
<p data-line="179" class="code-line">そのままPR（Pull request）を作成しました。PRの説明には背景や環境、<code>ostruct</code>の対応は敢えてしなかったことなどをなるべく丁寧に記述しました。</p>
<p data-line="181" class="code-line">実際のPR<br style="display:none">
<span class="embed-block zenn-embedded zenn-embedded-card"><iframe id="zenn-embedded__0f91a95d2f789" src="https://embed.zenn.studio/card#zenn-embedded__0f91a95d2f789" data-content="https%3A%2F%2Fgithub.com%2Frmosolgo%2Fgraphql-ruby%2Fpull%2F5341" frameborder="0" scrolling="no" loading="lazy"></iframe></span><a href="https://github.com/rmosolgo/graphql-ruby/pull/5341" style="display:none" target="_blank" rel="nofollow noopener noreferrer">https://github.com/rmosolgo/graphql-ruby/pull/5341</a></p>
<h2 id="pull-request%E3%81%AE%E3%81%9D%E3%81%AE%E5%BE%8C" data-line="184" class="code-line">
<a class="header-anchor-link" href="#pull-request%E3%81%AE%E3%81%9D%E3%81%AE%E5%BE%8C" aria-hidden="true"></a> Pull requestのその後</h2>
<blockquote data-line="186" class="code-line">
<p data-line="186" class="code-line">Hey, thanks for reporting this! When I saw require "benchmark" in the tests, something seemed strange to me ... I don't think the tests use Benchmark. So I removed it and found the tests ran fine.</p>
<p data-line="188" class="code-line">I added a CI build on head in <a href="https://github.com/rmosolgo/graphql-ruby/pull/5342" target="_blank" rel="nofollow noopener noreferrer">#5342</a>, and removed this line in that PR.</p>
</blockquote>
<p data-line="190" class="code-line">テストで<code>benchmark</code>を使っていない想定だったようで、メンテナーの方が先回りして直してくださいました。せっかくならコミュニケーション取りながら自分がcommitしたかった！ですが、初めてだったのでこれくらいで丁度良かったと思うことにします。</p>
<h1 id="%E3%81%BE%E3%81%A8%E3%82%81" data-line="192" class="code-line">
<a class="header-anchor-link" href="#%E3%81%BE%E3%81%A8%E3%82%81" aria-hidden="true"></a> まとめ</h1>
<p data-line="194" class="code-line">GitHub flowが初めてだったので、forkしてupsteramの設定など勉強になりました。Headで動かしてみるとissueが見つかりやすいかもしれないですね。</p>
<ul data-line="196" class="code-line">
<li data-line="196" class="code-line">
<strong>GitHub Flow:</strong> Forkして、ローカルで修正して、upstreamを設定して...という一連の流れを実際に体験できました<div class="code-block-container"><pre class="language-bash"><code class="language-bash code-line" data-line="197"><span class="token comment"># upstreamリモートを追加 (初回のみ)</span>
<span class="token function">git</span> remote <span class="token function">add</span> upstream https://github.com/rmosolgo/graphql-ruby.git
<span class="token comment"># 最新の変更を取り込む</span>
<span class="token function">git</span> fetch upstream
<span class="token function">git</span> merge upstream/master
</code></pre></div>
</li>
<li data-line="204" class="code-line">
<strong>Ruby Headバージョン:</strong> 最新の開発版を使うことで、ライブラリの潜在的な問題を発見しやすいかもしれないと感じました</li>
<li data-line="205" class="code-line">
<strong>OSSコミュニケーション:</strong> 拙い英語でも、丁寧に説明すればメンテナーの方がちゃんと読んでくれることが分かりました（今回は先回りされちゃいましたが！）</li>
</ul>
<p data-line="207" class="code-line"><span class="embed-block zenn-embedded zenn-embedded-tweet"><iframe id="zenn-embedded__a44182846c76b" src="https://embed.zenn.studio/tweet#zenn-embedded__a44182846c76b" data-content="https%3A%2F%2Fx.com%2Fkoxya%2Fstatus%2F1917008082636574801" frameborder="0" scrolling="no" loading="lazy"></iframe></span><a href="https://x.com/koxya/status/1917008082636574801" style="display:none" target="_blank" rel="nofollow noopener noreferrer">https://x.com/koxya/status/1917008082636574801</a></p>
<p data-line="209" class="code-line">初めてのOSSへのPRはドキドキしましたが、やってみると意外ハードルは低いのかなと思いました。<br>
この記事がこれからOSS活動を始めたいと思っている方の小さな一歩に繋がれば嬉しいです。</p>


初めてOSSにPRを投げた話

Discussion